Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340501 )
Change subject: VE: Don't load PRP target on all pages, just PRP pages.
......................................................................
VE: Don't load PRP target on all pages, just PRP pages.
Change-Id: Id6b07806f6fc6499198c9c3aea96ba40cf3e0c70
---
M extension.json
A modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
2 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/01/340501/1
diff --git a/extension.json b/extension.json
index 9294175..33ca862 100644
--- a/extension.json
+++ b/extension.json
@@ -123,7 +123,8 @@
"position": "top",
"styles": "page/ext.proofreadpage.page.css",
"dependencies": [
- "ext.proofreadpage.base"
+ "ext.proofreadpage.base",
+ "ext.proofreadpage.ve.pageTarget.init"
]
},
"ext.proofreadpage.page.edit": {
@@ -204,6 +205,11 @@
"targets": [
"desktop",
"mobile"
+ ]
+ },
+ "ext.proofreadpage.ve.pageTarget.init": {
+ "scripts": [
+
"ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js"
]
},
"ext.proofreadpage.ve.pageTarget": {
@@ -325,8 +331,7 @@
"tests/parser/proofreadpage_pagequality.txt"
],
"VisualEditorPluginModules": [
- "ext.proofreadpage.ve.node.pages",
- "ext.proofreadpage.ve.pageTarget"
+ "ext.proofreadpage.ve.node.pages"
],
"VisualEditorAvailableNamespaces": {
"Page": true
diff --git a/modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
b/modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
new file mode 100644
index 0000000..a0256ae
--- /dev/null
+++ b/modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
@@ -0,0 +1,15 @@
+/*!
+ * VisualEditor ProofreadPagePageTarget initialization.
+ *
+ * @copyright 2011-2016 VisualEditor Team and others; see AUTHORS.txt
+ * @license The MIT License (MIT); see LICENSE.txt
+ */
+
+( function () {
+ mw.loader.using( 'ext.visualEditor.desktopArticleTarget.init', function
() {
+ // Adding this module to VisualEditorPluginModules would cause
it to load on
+ // all VE-loading pages (even non PRP namespaces). Instead add
it to the plugin
+ // list here, only on pages that have loaded
'ext.proofreadpage.page' first.
+ mw.libs.ve.addPlugin( 'ext.proofreadpage.ve.pageTarget' );
+ } );
+} )();
--
To view, visit https://gerrit.wikimedia.org/r/340501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6b07806f6fc6499198c9c3aea96ba40cf3e0c70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
