D3r1ck01 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340566 )
Change subject: Removing double escaping of (un)subscribe message
......................................................................
Removing double escaping of (un)subscribe message
* (un)subscribe messages on buttons was double escaped which
was not supposed to.
Bug: T159075
Change-Id: I78fb71cd90c8832542ae4c6c3ecc802c02615a72
---
M includes/specials/SpecialNewsletter.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/66/340566/1
diff --git a/includes/specials/SpecialNewsletter.php
b/includes/specials/SpecialNewsletter.php
index 6f7e4be..7725813 100644
--- a/includes/specials/SpecialNewsletter.php
+++ b/includes/specials/SpecialNewsletter.php
@@ -139,7 +139,7 @@
$link = $linkRenderer->makeKnownLink( $title,
$msg, [], ['action'=>'edit'] );
}
if ( $current === $action ) {
- $links[] = Linker::makeSelfLinkObj( $title,
htmlspecialchars( $msg ) );
+ $links[] = Linker::makeSelfLinkObj( $title,
$msg );
} else {
$links[] = $link;
@@ -204,7 +204,7 @@
'unsubscribe' => array(
'type' => 'submit',
'name' => 'unsubscribe',
- 'default' => $this->msg(
'newsletter-do-unsubscribe' )->escaped(),
+ 'default' => $this->msg(
'newsletter-do-unsubscribe' )->text(),
'id' => 'mw-newsletter-unsubscribe',
'flags' => array( 'primary',
'destructive' ),
)
@@ -217,7 +217,7 @@
'subscribe' => array(
'type' => 'submit',
'name' => 'subscribe',
- 'default' => $this->msg(
'newsletter-do-subscribe' )->escaped(),
+ 'default' => $this->msg(
'newsletter-do-subscribe' )->text(),
'id' => 'mw-newsletter-subscribe',
'flags' => array( 'primary',
'constructive' ),
)
--
To view, visit https://gerrit.wikimedia.org/r/340566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78fb71cd90c8832542ae4c6c3ecc802c02615a72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: D3r1ck01 <alangider...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
