Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340670 )
Change subject: Performance: Move 'SearchSatisfaction' to only run on
non-Minerva skins
......................................................................
Performance: Move 'SearchSatisfaction' to only run on non-Minerva skins
This is a pretty huge amount of code, and it's being blindly downloaded by all
users on desktop and mobile, only to immediately stop executing if the skin is
Minerva (which theoretically would also happen on desktop, but no-one is going
to care). Instead, move the code to be a default skinScript, which is then not
loaded on Minerva.
Before this change ext.wikimediaEvents has an uncompressed size of 21.8 KiB as
the second largest module loaded on every mobile page; afterwards, it's cut by
more than half to 10.7 KiB on mobile, whilst desktop is unaffected.
Change-Id: I60a3a78fbbdf6ae00c9050a644b105dcc341c5ff
---
M extension.json
1 file changed, 6 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/70/340670/1
diff --git a/extension.json b/extension.json
index d21cbdc..1ef3327 100644
--- a/extension.json
+++ b/extension.json
@@ -141,9 +141,14 @@
"ext.wikimediaEvents.kartographer.js",
"ext.wikimediaEvents.readingDepth.js",
"ext.wikimediaEvents.rlfeature.js",
- "ext.wikimediaEvents.searchSatisfaction.js",
"ext.wikimediaEvents.geoFeatures.js"
],
+ "skinScripts": {
+ "default": [
+
"ext.wikimediaEvents.searchSatisfaction.js"
+ ],
+ "minerva": []
+ },
"dependencies": [
"ext.eventLogging.subscriber",
"mediawiki.user",
--
To view, visit https://gerrit.wikimedia.org/r/340670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60a3a78fbbdf6ae00c9050a644b105dcc341c5ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
