jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/340892 )
Change subject: startup: Drop JavaScript support for browsers without DOM Level
2
......................................................................
startup: Drop JavaScript support for browsers without DOM Level 2
In practice, this means nothing, as the main browsers affected
were Internet Explorer 8 and early versions of Android (before
1.6), which are already Grade C.
Change-Id: I4488402686c8b9fefa0af5fed3c9a4b83cbff798
---
M resources/Resources.php
D resources/src/dom-level2-skip.js
D resources/src/polyfill-nodeTypes.js
M tests/qunit/QUnitTestResources.php
4 files changed, 3 insertions(+), 35 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index 5406480..ea97337 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -251,7 +251,6 @@
'scripts' => 'resources/src/jquery/jquery.highlightText.js',
'dependencies' => [
'mediawiki.RegExp',
- 'dom-level2-shim',
],
'targets' => [ 'desktop', 'mobile' ],
],
@@ -345,7 +344,6 @@
'styles' => 'resources/src/jquery/jquery.tablesorter.less',
'messages' => [ 'sort-descending', 'sort-ascending' ],
'dependencies' => [
- 'dom-level2-shim',
'mediawiki.RegExp',
'mediawiki.language.months',
],
@@ -736,7 +734,7 @@
// Deprecated since MediaWiki 1.29.0
'json' => [
- 'deprecated' => 'Use of the "json" MediaWiki module is
deprecated since MediaWiki 1.29.0',
+ 'deprecated' => 'Use of the "json" module is deprecated since
MediaWiki 1.29.0',
'targets' => [ 'desktop', 'mobile' ],
],
@@ -937,7 +935,6 @@
'mediawiki.api.upload' => [
'scripts' => 'resources/src/mediawiki/api/upload.js',
'dependencies' => [
- 'dom-level2-shim',
'mediawiki.api',
'mediawiki.api.edit',
],
@@ -1220,7 +1217,6 @@
'mediawiki.Upload' => [
'scripts' => 'resources/src/mediawiki/mediawiki.Upload.js',
'dependencies' => [
- 'dom-level2-shim',
'mediawiki.api.upload',
],
],
@@ -1612,7 +1608,6 @@
'mediawiki.util',
'mediawiki.language',
'user.options',
- 'dom-level2-shim',
],
'targets' => [ 'desktop', 'mobile' ],
],
@@ -2490,11 +2485,10 @@
],
/* dom-level2-shim */
- // IE 8
+ // Deprecated since MediaWiki 1.29.0
'dom-level2-shim' => [
- 'scripts' => 'resources/src/polyfill-nodeTypes.js',
+ 'deprecated' => 'Use of the "dom-level2-shim" module is
deprecated since MediaWiki 1.29.0',
'targets' => [ 'desktop', 'mobile' ],
- 'skipFunction' => 'resources/src/dom-level2-skip.js',
],
/* OOjs */
diff --git a/resources/src/dom-level2-skip.js b/resources/src/dom-level2-skip.js
deleted file mode 100644
index 484c295..0000000
--- a/resources/src/dom-level2-skip.js
+++ /dev/null
@@ -1,6 +0,0 @@
-/*!
- * Skip function for dom-level2-shim module.
- *
- * Tests for window.Node because that's the only thing that this shim is
adding.
- */
-return !!window.Node;
diff --git a/resources/src/polyfill-nodeTypes.js
b/resources/src/polyfill-nodeTypes.js
deleted file mode 100644
index c8acc86..0000000
--- a/resources/src/polyfill-nodeTypes.js
+++ /dev/null
@@ -1,19 +0,0 @@
-/**
- * Adds window.Node with node types according to:
- * https://www.w3.org/TR/DOM-Level-2-Core/core.html#ID-1950641247
- */
-
-window.Node = window.Node || {
- ELEMENT_NODE: 1,
- ATTRIBUTE_NODE: 2,
- TEXT_NODE: 3,
- CDATA_SECTION_NODE: 4,
- ENTITY_REFERENCE_NODE: 5,
- ENTITY_NODE: 6,
- PROCESSING_INSTRUCTION_NODE: 7,
- COMMENT_NODE: 8,
- DOCUMENT_NODE: 9,
- DOCUMENT_TYPE_NODE: 10,
- DOCUMENT_FRAGMENT_NODE: 11,
- NOTATION_NODE: 12
-};
diff --git a/tests/qunit/QUnitTestResources.php
b/tests/qunit/QUnitTestResources.php
index 94d25ee..0bd190b 100644
--- a/tests/qunit/QUnitTestResources.php
+++ b/tests/qunit/QUnitTestResources.php
@@ -32,7 +32,6 @@
'mediawiki.page.ready',
'mediawiki.page.startup',
'test.sinonjs',
- 'dom-level2-shim',
],
'position' => 'top',
'targets' => [ 'desktop', 'mobile' ],
--
To view, visit https://gerrit.wikimedia.org/r/340892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4488402686c8b9fefa0af5fed3c9a4b83cbff798
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
