Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/341454 )
Change subject: [DEPRECATING CHANGE] icons: Move 'add' from core to
'interactions' pack
......................................................................
[DEPRECATING CHANGE] icons: Move 'add' from core to 'interactions' pack
Change-Id: Ib6b361d8cc2e25713b7bd7bd481f9cac27eda5a2
---
M demos/pages/icons.js
M src/themes/apex/icons-interactions.json
M src/themes/apex/icons.json
M src/themes/mediawiki/icons-interactions.json
M src/themes/mediawiki/icons.json
5 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/54/341454/1
diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index ebf07c1..9118dc0 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -2,7 +2,6 @@
var i, len, iconSet, iconsFieldset, iconWidget, selector,
icons = {
core: [
- 'add',
'advanced',
'alert',
'cancel',
@@ -64,6 +63,7 @@
'tray'
],
interactions: [
+ 'add',
'bookmark',
'browser',
'clear',
diff --git a/src/themes/apex/icons-interactions.json
b/src/themes/apex/icons-interactions.json
index d68e70c..c6de0c4 100644
--- a/src/themes/apex/icons-interactions.json
+++ b/src/themes/apex/icons-interactions.json
@@ -8,6 +8,7 @@
}
},
"images": {
+ "add": { "file": "images/icons/add.svg" },
"beta": { "file": "images/icons/beta.svg" },
"betaLaunch": { "file":
"images/icons/logo-wikimediaDiscovery.svg" },
"bookmark": { "file": {
diff --git a/src/themes/apex/icons.json b/src/themes/apex/icons.json
index b5fbbed..2100dc2 100644
--- a/src/themes/apex/icons.json
+++ b/src/themes/apex/icons.json
@@ -2,7 +2,7 @@
"prefix": "oo-ui-icon",
"intro": "@import '../../../../src/styles/common';",
"images": {
- "add": { "file": "images/icons/add.svg" },
+ "add": { "file": "images/icons/add.svg", "deprecated": "Please
use the icon 'add' in the interactions pack" },
"advanced": { "file": "images/icons/advanced.svg" },
"alert": { "file": "images/icons/alert.svg" },
"cancel": { "file": "images/icons/cancel.svg" },
diff --git a/src/themes/mediawiki/icons-interactions.json
b/src/themes/mediawiki/icons-interactions.json
index 3436446..3adeb02 100644
--- a/src/themes/mediawiki/icons-interactions.json
+++ b/src/themes/mediawiki/icons-interactions.json
@@ -22,6 +22,7 @@
}
},
"images": {
+ "add": { "file": "images/icons/add.svg", "variants": [
"constructive", "progressive" ] },
"beta": { "file": "images/icons/beta.svg" },
"betaLaunch": { "file":
"images/icons/logo-wikimediaDiscovery.svg" },
"bookmark": { "file": {
diff --git a/src/themes/mediawiki/icons.json b/src/themes/mediawiki/icons.json
index 9a625bf..9a85d25 100644
--- a/src/themes/mediawiki/icons.json
+++ b/src/themes/mediawiki/icons.json
@@ -22,7 +22,7 @@
}
},
"images": {
- "add": { "file": "images/icons/add.svg", "variants": [
"constructive", "progressive" ] },
+ "add": { "file": "images/icons/add.svg", "variants": [
"constructive", "progressive" ], "deprecated": "Please use the icon 'add' in
the interactions pack" },
"advanced": { "file": "images/icons/advanced.svg" },
"alert": { "file": "images/icons/alert.svg", "variants": [
"warning" ] },
"cancel": { "file": "images/icons/cancel.svg", "variants": [
"destructive" ] },
--
To view, visit https://gerrit.wikimedia.org/r/341454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6b361d8cc2e25713b7bd7bd481f9cac27eda5a2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
