jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/335172 )
Change subject: Ensure the editing textarea is not higher than browser's viewport ...................................................................... Ensure the editing textarea is not higher than browser's viewport Limit it to 100vh. 'vh' is a new unit introduced in CSS3, representing 1% of the viewport height, and fairly widely supported in today's browsers: <http://caniuse.com/#feat=viewport-units>. Bug: T155886 Change-Id: I4a32d7d5c4eb110c9ecd0b6b13e4c176d343d82f --- M resources/src/mediawiki.action/mediawiki.action.edit.styles.css 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Krinkle: Looks good to me, but someone else must approve jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css index 0ee4058..d288e6b 100644 --- a/resources/src/mediawiki.action/mediawiki.action.edit.styles.css +++ b/resources/src/mediawiki.action/mediawiki.action.edit.styles.css @@ -6,6 +6,10 @@ #wpTextbox1 { margin: 0; display: block; + /* Ensure the textarea is not higher than browser's viewport on small screens */ + max-height: 100vh; + /* But don't let it collapse into nothingness on really tiny screens */ + min-height: 5em; } /* Adjustments to edit form elements */ -- To view, visit https://gerrit.wikimedia.org/r/335172 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a32d7d5c4eb110c9ecd0b6b13e4c176d343d82f Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: John Erling Blad <jeb...@gmail.com> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: TTO <at.li...@live.com.au> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: WMDE-jand <jan.dittr...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
