Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/326150 )
Change subject: Gerrit: Enable config localUsernameToLowerCase ...................................................................... Gerrit: Enable config localUsernameToLowerCase This will allow users to login either with capitals in there username or lowercase fixing T152640 There will need to be a fix applied to the core of gerrit to fix T152640 completely as the current gerrit version we use causes the external id rows to be deleted. Luckly upstream have fixed this now. Note: Do not merge this without demon / Chad +1 as this will break all users login who use an uppercase username as all usernames need to be converted to lowercase which will then allow users to login with uppercase. will require down time. https://gerrit-review.googlesource.com/Documentation/pgm-LocalUsernamesToLowerCase.html https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#ldap.localUsernameToLowerCase I've done all the testing on a dev install and looks promising to fixing the problem. Bug: T152640 Bug: T155766 Change-Id: I723443d676e46e2bc5bb408b0a874dcce66a4e18 --- M modules/gerrit/templates/gerrit.config.erb 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Chad: Looks good to me, but someone else must approve jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/gerrit/templates/gerrit.config.erb b/modules/gerrit/templates/gerrit.config.erb index 7d5479f..876bb77 100644 --- a/modules/gerrit/templates/gerrit.config.erb +++ b/modules/gerrit/templates/gerrit.config.erb @@ -27,6 +27,8 @@ groupBase = ou=groups,<%= @ldap_base_dn %> groupMemberPattern = (&(objectClass=groupOfNames)(member=${dn})) groupScope = one + # Fixes T152640 + localUsernameToLowerCase = true [sendemail] includeDiff = true smtpServerPort = 25 -- To view, visit https://gerrit.wikimedia.org/r/326150 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723443d676e46e2bc5bb408b0a874dcce66a4e18 Gerrit-PatchSet: 9 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: 20after4 <mmod...@wikimedia.org> Gerrit-Reviewer: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
