Awight has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/341477 )
Change subject: Comments
......................................................................
Comments
Change-Id: Ifd5ca54fd01546feff13a685885c56fdbe5df1ee
---
A docs/Normal submit sequence.zargo
M gateway_common/GatewayPage.php
2 files changed, 6 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/77/341477/1
diff --git a/docs/Normal submit sequence.zargo b/docs/Normal submit
sequence.zargo
new file mode 100644
index 0000000..39c236b
--- /dev/null
+++ b/docs/Normal submit sequence.zargo
Binary files differ
diff --git a/gateway_common/GatewayPage.php b/gateway_common/GatewayPage.php
index 6aa2602..491add7 100644
--- a/gateway_common/GatewayPage.php
+++ b/gateway_common/GatewayPage.php
@@ -148,6 +148,10 @@
/**
* Should be overridden in each derived class to actually handle the
request
* Performs gateway-specific checks and either redirects or displays
form.
+ *
+ * FIXME: Be more disciplined about how handleRequest fits with
+ * handleDonationRequest. Would it be cleaner to move to a pre and post
+ * hook scheme?
*/
protected abstract function handleRequest();
@@ -211,6 +215,8 @@
if ( $this->adapter && $allowRapid ) {
$page = ResultPages::getFailPage( $this->adapter );
+ // FIXME: Structured data $page rather than a union.
displayForm
+ // will add the ffname if needed.
if ( !filter_var( $page, FILTER_VALIDATE_URL ) ) {
// If it's not a URL, we're rendering a
RapidFail form
$this->logger->info( "Displaying fail form
$page" );
--
To view, visit https://gerrit.wikimedia.org/r/341477
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd5ca54fd01546feff13a685885c56fdbe5df1ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
