Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/341495 )
Change subject: Avoid invalid characters in memcache keys
......................................................................
Avoid invalid characters in memcache keys
Just sha1() the namespace and title before they are used in the memcache
key.
Bug: T159783
Change-Id: Ieef5c8383f4d6b61158450e1eff6c04a85ed4a27
---
M includes/JCCache.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/JsonConfig
refs/changes/95/341495/1
diff --git a/includes/JCCache.php b/includes/JCCache.php
index c352a65..3cda3bb 100644
--- a/includes/JCCache.php
+++ b/includes/JCCache.php
@@ -33,8 +33,10 @@
$wgJsonConfigCacheKeyPrefix,
$conf->cacheKey,
( $flRev === null ? '' : ( $flRev ? 'T' : 'F' ) ),
- $titleValue->getNamespace(),
- $titleValue->getDBkey()
+ sha1(
+ $titleValue->getNamespace(),
+ $titleValue->getDBkey()
+ )
] );
if ( $conf->isLocal ) {
$key = wfMemcKey( $key );
--
To view, visit https://gerrit.wikimedia.org/r/341495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieef5c8383f4d6b61158450e1eff6c04a85ed4a27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
