Mholloway has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341830 )
Change subject: Hygiene: Remove SDK Manager plugin ...................................................................... Hygiene: Remove SDK Manager plugin Since version 2.2.0, the Android Gradle plugin should automatically download packages that a project depends on. This makes the SDK Manager plugin obsolete, and it's been deprecated since then. We've been keeping it for CI, but the CI SDK environments are in theory maintained by the Jenkins Android emulator plugin[1]; in any case, it seems that even with both the Jenkins plugin and the project-level SDK Manager plugin, SDK updates aren't being downloaded as expected.[2] That being the case, there's no longer any reason to keep the SDK Manager plugin. [1] https://wiki.jenkins-ci.org/display/JENKINS/Android+Emulator+Plugin [2] T158456 Bug: T147099 Change-Id: I9c865b7e3db4146068306c909e5d1d5b047ac698 --- M app/build.gradle M build.gradle 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/30/341830/1 diff --git a/app/build.gradle b/app/build.gradle index 5a3bc27..bbcac7c 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -1,4 +1,3 @@ -apply plugin: 'android-sdk-manager' apply plugin: 'com.android.application' apply plugin: 'com.neenbedankt.android-apt' diff --git a/build.gradle b/build.gradle index 864a3a3..6007258 100644 --- a/build.gradle +++ b/build.gradle @@ -6,7 +6,6 @@ dependencies { classpath 'com.android.tools.build:gradle:2.2.3' classpath 'com.facebook.testing.screenshot:plugin:0.4.2' - classpath 'com.github.JakeWharton:sdk-manager-plugin:1d07987' classpath 'org.gradle.api.plugins:gradle-nexus-plugin:0.7.1' classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8' classpath 'com.stanfy.spoon:spoon-gradle-plugin:1.1.0' -- To view, visit https://gerrit.wikimedia.org/r/341830 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c865b7e3db4146068306c909e5d1d5b047ac698 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway <mhollo...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
