Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/341952 )
Change subject: Switch from .parent hack to use .super directly
......................................................................
Switch from .parent hack to use .super directly
Change-Id: Ib582a28308c0d25e9fa9cd97975834fbf8507440
---
M Gruntfile.js
M src/Factory.js
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/52/341952/1
diff --git a/Gruntfile.js b/Gruntfile.js
index a7b6082..c5f1c24 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -173,7 +173,7 @@
} );
grunt.registerTask( 'build', [ 'clean', 'concat', 'uglify' ] );
- grunt.registerTask( '_test', [ 'git-build', 'build', 'eslint',
'karma:main', 'karma:jquery', 'karma:other' ] );
+ grunt.registerTask( '_test', [ 'git-build', 'build', 'eslint:dev',
'karma:main', 'karma:jquery', 'karma:other' ] );
grunt.registerTask( 'ci', [ '_test', 'karma:ci' ] );
if ( process.env.ZUUL_PIPELINE === 'gate-and-submit' ) {
diff --git a/src/Factory.js b/src/Factory.js
index 3aad31f..9ee8715 100644
--- a/src/Factory.js
+++ b/src/Factory.js
@@ -6,7 +6,7 @@
*/
oo.Factory = function OoFactory() {
// Parent constructor
- oo.Factory.parent.call( this );
+ oo.Factory.super.call( this );
};
/* Inheritance */
@@ -43,7 +43,7 @@
}
// Parent method
- oo.Factory.parent.prototype.register.call( this, name, constructor );
+ oo.Factory.super.prototype.register.call( this, name, constructor );
};
/**
@@ -65,7 +65,7 @@
}
// Parent method
- oo.Factory.parent.prototype.unregister.call( this, name );
+ oo.Factory.super.prototype.unregister.call( this, name );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/341952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib582a28308c0d25e9fa9cd97975834fbf8507440
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
