Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/341966 )
Change subject: authdns: fix lint warning
......................................................................
authdns: fix lint warning
puppet-lint 2.1.2.pre tells us:
WARNING: optional parameter listed before required parameter on line 9
WARNING: optional parameter listed before required parameter on line 10
Change-Id: I4d48fb902139e76fb73aaf7549a9b08c0f220c4f
---
M modules/authdns/manifests/init.pp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/modules/authdns/manifests/init.pp
b/modules/authdns/manifests/init.pp
index 6202faf..1f666b9 100644
--- a/modules/authdns/manifests/init.pp
+++ b/modules/authdns/manifests/init.pp
@@ -2,12 +2,12 @@
# A class to implement Wikimedia's authoritative DNS system
#
class authdns(
+ $lvs_services,
+ $discovery_services,
$nameservers = [ $::fqdn ],
$gitrepo = undef,
$monitoring = true,
$conftool_prefix = hiera('conftool_prefix'),
- $lvs_services,
- $discovery_services,
) {
require ::authdns::account
require ::authdns::scripts
--
To view, visit https://gerrit.wikimedia.org/r/341966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d48fb902139e76fb73aaf7549a9b08c0f220c4f
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
