jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/341471 )
Change subject: Log events to statsv for monitoring PagePreviews performance ...................................................................... Log events to statsv for monitoring PagePreviews performance For logging to work: 1. $wgWMEStatsdBaseUri needs to point to a valid statsv endpoint, e.g. 'https://en.wikipedia.org/beacon/statsv'. 2. $wgPopupsStatsvSamplingRate needs to be set. Note that the codebase already contains the EventLogging functionality, which is configured separately. Separately configuring different logging mechanisms allows us to avoid sampling mistakes that may arise while choosing one or the other. For example, let's say we want to use EventLogging for 10% of users and statsv for 5%. We'd sample all users into two buckets: 50/50. And then we'd have to set the sampling rates as 20% and 10% respectively, only because of the bucketing above. To avoid this kind of complications, separate sampling rates are used for each logging mechanism. This, of course, may result in situations where a session is logged via both EventLogging and statsv. 3. The WikimediaEvents extension needs to be installed. The extension adds the `ext.wikimediaEvents` module to the output page. The logging functionality is delegated to this module. Notable changes: * The FETCH_START and FETCH_END actions are converted to a timed action. * The experiments stub used in tests has been extracted to the stubs file. Logged data is visualized at https://grafana.wikimedia.org/dashboard/db/reading-web-page-previews Bug: T157111 Change-Id: If3f1a06f1f623e8e625b6c30a48b7f5aa9de24db --- M doc/instrumentation.md M extension.json M includes/PopupsHooks.php M resources/dist/index.js M resources/dist/index.js.map M src/actionTypes.js M src/actions.js M src/changeListeners/index.js A src/changeListeners/statsv.js M src/index.js M src/reducers/index.js A src/reducers/statsv.js A src/statsvInstrumentation.js M tests/node-qunit/actions.test.js A tests/node-qunit/changeListeners/statsv.test.js M tests/node-qunit/isEnabled.test.js A tests/node-qunit/reducers/statsv.test.js A tests/node-qunit/statsvInstrumentation.test.js M tests/node-qunit/stubs.js M tests/phpunit/PopupsHooksTest.php 20 files changed, 584 insertions(+), 40 deletions(-) Approvals: jenkins-bot: Verified Phuedx: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/341471 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f1a06f1f623e8e625b6c30a48b7f5aa9de24db Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
