Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343228 )
Change subject: DesktopContext: on destroy, tell our popup to stop positioning
......................................................................
DesktopContext: on destroy, tell our popup to stop positioning
When a popup is in positioning-mode, it has a scroll event bound on its
context. This can cause issues, as we're removing everything it relies on from
the DOM and discarding it.
Bug: T160197
Change-Id: Iad4fd3462c38c8e0fc55fb51a9429d922fa21817
(cherry picked from commit 96619eefbe73f5a47eb136901e2e35c8a43fd159)
---
M src/ui/contexts/ve.ui.DesktopContext.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/28/343228/1
diff --git a/src/ui/contexts/ve.ui.DesktopContext.js
b/src/ui/contexts/ve.ui.DesktopContext.js
index 16b6da5..baa21f0 100644
--- a/src/ui/contexts/ve.ui.DesktopContext.js
+++ b/src/ui/contexts/ve.ui.DesktopContext.js
@@ -430,6 +430,8 @@
resize: this.onWindowResizeHandler,
scroll: this.onWindowScrollDebounced
} );
+ // Popups bind scroll events if they're in positioning mode, so make
sure that's disabled
+ this.popup.togglePositioning( false );
// Parent method
return ve.ui.DesktopContext.super.prototype.destroy.call( this );
--
To view, visit https://gerrit.wikimedia.org/r/343228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad4fd3462c38c8e0fc55fb51a9429d922fa21817
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.29.0-wmf.16
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
