Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343242 )
Change subject: MWExceptionRenderer: Don't try to use OutputPage without a Title
......................................................................
MWExceptionRenderer: Don't try to use OutputPage without a Title
While OutputPage might not depend on having a Title set up,
it has many hooks, and extensions using them might.
Example way to reproduce the problem: cause a fatal in
ResourceLoaderFileModule::getDefinitionSummary() while
having the MultimediaViewer extension installed.
Change-Id: Id356dfafb2c66ca0c85eb08dac421dbb6f911d63
---
M includes/exception/MWExceptionRenderer.php
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/42/343242/1
diff --git a/includes/exception/MWExceptionRenderer.php
b/includes/exception/MWExceptionRenderer.php
index a569bcd..59c8be8 100644
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -136,9 +136,13 @@
}
}
+ // Has the OutputPage been set up, and does it have basic stuff
like a Title?
+ if ( empty( $GLOBALS['wgOut'] ) ||
!$GLOBALS['wgOut']->getTitle() ) {
+ return false;
+ }
+
return (
!empty( $GLOBALS['wgFullyInitialised'] ) &&
- !empty( $GLOBALS['wgOut'] ) &&
!defined( 'MEDIAWIKI_INSTALL' )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/343242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id356dfafb2c66ca0c85eb08dac421dbb6f911d63
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
