Muehlenhoff has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/343252 )

Change subject: Fix -turn-volunteer mode in LDAP offboarding script
......................................................................

Fix -turn-volunteer mode in LDAP offboarding script

New volunteer should be added to cn=nda, not readded to cn=wmf...

Change-Id: Iddfddc7995f2e98331bbf5fe1f092ee22da3b076
---
M modules/openldap/files/offboard-user.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/52/343252/1

diff --git a/modules/openldap/files/offboard-user.py 
b/modules/openldap/files/offboard-user.py
index 4580bef..41bb609 100644
--- a/modules/openldap/files/offboard-user.py
+++ b/modules/openldap/files/offboard-user.py
@@ -135,7 +135,7 @@
                 if turn_volunteer:
                     if priv_group == 'cn=wmf,ou=groups,dc=wikimedia,dc=org':
                         ldif += REMOVE_GROUP.format(group_name=priv_group, 
user_dn=user_dn)
-                        ldif += ADD_GROUP.format(group_name=priv_group, 
user_dn=user_dn)
+                        ldif += 
ADD_GROUP.format(group_name='cn=nda,ou=groups,dc=wikimedia,dc=org', 
user_dn=user_dn)
                         print "  ", priv_group, "(converted to nda group)"
                     else:
                         print "  ", priv_group, "(can be retained)"

-- 
To view, visit https://gerrit.wikimedia.org/r/343252
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddfddc7995f2e98331bbf5fe1f092ee22da3b076
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <mmuhlenh...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to