Rush has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/341607 )
Change subject: etcd: etcd-backup.py needs a type set for argparse 'keep'
......................................................................
etcd: etcd-backup.py needs a type set for argparse 'keep'
etcd-backup.py test /root/ --keep 1
> TypeError: unsupported operand type(s) for -: 'int' and 'str'
Change-Id: Icb2e931806227b619542d1e2823f0e96ec6529ff
---
M modules/etcd/files/etcd-backup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
Rush: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/etcd/files/etcd-backup.py
b/modules/etcd/files/etcd-backup.py
index f6284b4..e6f1da1 100755
--- a/modules/etcd/files/etcd-backup.py
+++ b/modules/etcd/files/etcd-backup.py
@@ -90,7 +90,7 @@
parser.add_argument('cluster_name', help="Name of the cluster")
parser.add_argument('backup_dir', help="Backup directory (full path)")
parser.add_argument(
- '--keep', default=7,
+ '--keep', type=int, default=7,
help="Number of old backups to keep")
args = parser.parse_args()
rotate_logs(args.cluster_name, args.backup_dir, args.keep)
--
To view, visit https://gerrit.wikimedia.org/r/341607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb2e931806227b619542d1e2823f0e96ec6529ff
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
