Aude has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343531 )
Change subject: Improve variable naming in ItemHandlerTest ...................................................................... Improve variable naming in ItemHandlerTest Change-Id: I60bebd8f6db40bdea2a587500449ddd96847c3da --- M repo/tests/phpunit/includes/Content/ItemHandlerTest.php 1 file changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/31/343531/1 diff --git a/repo/tests/phpunit/includes/Content/ItemHandlerTest.php b/repo/tests/phpunit/includes/Content/ItemHandlerTest.php index 70259b3..87249b7 100644 --- a/repo/tests/phpunit/includes/Content/ItemHandlerTest.php +++ b/repo/tests/phpunit/includes/Content/ItemHandlerTest.php @@ -67,24 +67,24 @@ public function provideGetUndoContent() { $cases = parent::provideGetUndoContent(); - $e1 = $this->newEntity(); - $e1->setLabel( 'en', 'Foo' ); - $r1 = $this->fakeRevision( $this->newEntityContent( $e1 ), 11 ); + $item1 = $this->newEntity(); + $item1->setLabel( 'en', 'Foo' ); + $rev1 = $this->fakeRevision( $this->newEntityContent( $item1 ), 11 ); - $e2 = $this->newRedirectContent( $e1->getId(), new ItemId( 'Q112' ) ); - $r2 = $this->fakeRevision( $e2, 12 ); + $itemContent1 = $this->newRedirectItemContent( $item1->getId(), new ItemId( 'Q112' ) ); + $rev2 = $this->fakeRevision( $itemContent1, 12 ); - $e3 = $this->newRedirectContent( $e1->getId(), new ItemId( 'Q113' ) ); - $r3 = $this->fakeRevision( $e3, 13 ); + $itemContent2 = $this->newRedirectItemContent( $item1->getId(), new ItemId( 'Q113' ) ); + $rev3 = $this->fakeRevision( $itemContent2, 13 ); - $e4 = $this->newEntity(); - $e4->setLabel( 'en', 'Bar' ); - $r4 = $this->fakeRevision( $this->newEntityContent( $e4 ), 14 ); + $item2= $this->newEntity(); + $item2->setLabel( 'en', 'Bar' ); + $rev4 = $this->fakeRevision( $this->newEntityContent( $item2 ), 14 ); - $cases[] = array( $r2, $r2, $r1, $this->newEntityContent( $e1 ), "undo redirect" ); - $cases[] = array( $r3, $r3, $r2, $e2, "undo redirect change" ); - $cases[] = array( $r3, $r2, $r1, null, "undo redirect conflict" ); - $cases[] = array( $r4, $r4, $r3, $e3, "redo redirect" ); + $cases[] = [ $rev2, $rev2, $rev1, $this->newEntityContent( $item1 ), "undo redirect" ]; + $cases[] = [ $rev3, $rev3, $rev2, $itemContent1, "undo redirect change" ]; + $cases[] = [ $rev3, $rev2, $rev1, null, "undo redirect conflict" ]; + $cases[] = [ $rev4, $rev4, $rev3, $itemContent2, "redo redirect" ]; return $cases; } -- To view, visit https://gerrit.wikimedia.org/r/343531 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I60bebd8f6db40bdea2a587500449ddd96847c3da Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits