Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/322907 )
Change subject: puppet-lint: ignore 'lines over 140 chars' warnings ...................................................................... puppet-lint: ignore 'lines over 140 chars' warnings This will mean that jenkins bot will never downvote changes for long lines, even if they are over 140 chars , as opposed to 80 chars, which we already ignore. In puppet-lint 2 there is a new check for lines over 140 chars besides the existing one for lines over 80 chars. puppet-lint got bumped to 2.0.2 by 74a3d73d4f So far we said "won't fix" to the "over 80" check, with a comment of "we want at least 100", now the question is what we say to 140 as the limit. Bug:T144667 Bug:T93645 Change-Id: I296d541744f82d0138ad5adaeab5d48d7eae36da --- M .puppet-lint.rc 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dzahn: Verified; Looks good to me, approved diff --git a/.puppet-lint.rc b/.puppet-lint.rc index 71d706f..8adf103 100644 --- a/.puppet-lint.rc +++ b/.puppet-lint.rc @@ -1,6 +1,8 @@ # WONTFIX - We want at least 100. # Lot of long lines (ssh keys for example). --no-80chars-check +# even longer lines are also around +--no-140chars-check # T127797 - needs at least one comment line for each class --no-documentation-check -- To view, visit https://gerrit.wikimedia.org/r/322907 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I296d541744f82d0138ad5adaeab5d48d7eae36da Gerrit-PatchSet: 7 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org> Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org> Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Volans <rcocci...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
