Yaron Koren has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343816 )
Change subject: Fix for 55da4fa97568 - fixed local autocompletion for "text with autocomplete" ...................................................................... Fix for 55da4fa97568 - fixed local autocompletion for "text with autocomplete" It was giving the error "TypeError: this.source is not a function". Change-Id: Id72f8a9adb2638a579cec31384f8c097a4f3d107 --- M libs/PageForms.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaron Koren: Looks good to me, approved jenkins-bot: Verified diff --git a/libs/PageForms.js b/libs/PageForms.js index d7b79b1..598b6a5 100644 --- a/libs/PageForms.js +++ b/libs/PageForms.js @@ -154,7 +154,7 @@ } else { // Autocomplete for a single value $(this).autocomplete({ - source:values + source: ( typeof values === 'object' ) ? Object.values( values ) : values }); } } else { -- To view, visit https://gerrit.wikimedia.org/r/343816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id72f8a9adb2638a579cec31384f8c097a4f3d107 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/PageForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits