Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344430 )

Change subject: Headers default to empty array, not null
......................................................................

Headers default to empty array, not null

Prevents an e_notice if user doesn't set any headers.

Change-Id: Ic62f2b66848347905844b2726e1366bdae234407
---
M Core/Http/OutboundRequest.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/30/344430/1

diff --git a/Core/Http/OutboundRequest.php b/Core/Http/OutboundRequest.php
index 92e6cae..8eeb187 100644
--- a/Core/Http/OutboundRequest.php
+++ b/Core/Http/OutboundRequest.php
@@ -12,15 +12,18 @@
        /**
         * @var array
         */
-       protected $headers;
+       protected $headers = array();
+
        /**
         * @var Configuration
         */
        protected $config;
+
        /**
         * @var string HTTP method
         */
        protected $method;
+
        /**
         * @var string Request body
         */

-- 
To view, visit https://gerrit.wikimedia.org/r/344430
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic62f2b66848347905844b2726e1366bdae234407
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to