Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344567 )
Change subject: [FAILING TEST CASE] Minimal diff when word starts the paragraph ...................................................................... [FAILING TEST CASE] Minimal diff when word starts the paragraph Bug: T160795 Change-Id: I3ec474a636cb1bba6e6138f585c43cf5a002068d --- M tests/ui/ve.ui.DiffElement.test.js 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/67/344567/1 diff --git a/tests/ui/ve.ui.DiffElement.test.js b/tests/ui/ve.ui.DiffElement.test.js index 287800f..15a857c 100644 --- a/tests/ui/ve.ui.DiffElement.test.js +++ b/tests/ui/ve.ui.DiffElement.test.js @@ -30,6 +30,31 @@ '</div>' }, { + msg: 'Minimal text change', + oldDoc: '<p>foo bar baz</p>', + newDoc: '<p>foo bar! baz</p>', + expected: + '<div class="ve-ui-diffElement-doc-child-change">' + + '<p>' + + 'foo bar' + + '<ins data-diff-action="insert">!</ins>' + + ' baz' + + '</p>' + + '</div>' + }, + { + msg: 'Minimal text change at start of paragraph', + oldDoc: '<p>foo bar baz</p>', + newDoc: '<p>foo! bar baz</p>', + expected: + '<div class="ve-ui-diffElement-doc-child-change">' + + '<p>' + 'foo ' + + '<ins data-diff-action="insert">!</ins>' + + ' bar baz' + + '</p>' + + '</div>' + }, + { msg: 'Non semantic whitespace change (no diff)', oldDoc: '<p>foo</p>', newDoc: '<p> foo </p>', -- To view, visit https://gerrit.wikimedia.org/r/344567 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ec474a636cb1bba6e6138f585c43cf5a002068d Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester <jforres...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits