jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344581 )
Change subject: Replace deprecated jQuery .bind() by .on() ...................................................................... Replace deprecated jQuery .bind() by .on() jQuery .bind() is deprecated since jQuery 3.0. https://api.jquery.com/bind/ Change-Id: Ibbcfbefe2983b2ed2e3b110518c16539cbb84d88 --- M modules/jquery.wikiEditor.dialogs.js 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified TheDJ: Looks good to me, approved diff --git a/modules/jquery.wikiEditor.dialogs.js b/modules/jquery.wikiEditor.dialogs.js index 168a497..23d82f8 100644 --- a/modules/jquery.wikiEditor.dialogs.js +++ b/modules/jquery.wikiEditor.dialogs.js @@ -165,13 +165,13 @@ .find( 'button' ).not( '[tabindex]' ) ); if ( !( 'resizeme' in module ) || module.resizeme ) { $dialogDiv - .bind( 'dialogopen', $.wikiEditor.modules.dialogs.fn.resize ) - .find( '.ui-tabs' ).bind( 'tabsshow', function () { + .on( 'dialogopen', $.wikiEditor.modules.dialogs.fn.resize ) + .find( '.ui-tabs' ).on( 'tabsshow', function () { $( this ).closest( '.ui-dialog-content' ).each( $.wikiEditor.modules.dialogs.fn.resize ); } ); } - $dialogDiv.bind( 'dialogclose', function () { + $dialogDiv.on( 'dialogclose', function () { context.fn.restoreSelection(); } ); @@ -182,7 +182,7 @@ /** * Resize a dialog so its contents fit * - * Usage: dialog.each( resize ); or dialog.bind( 'blah', resize ); + * Usage: dialog.each( resize ); or dialog.on( 'blah', resize ); * NOTE: This function assumes $.ui.dialog has already been loaded */ resize: function () { -- To view, visit https://gerrit.wikimedia.org/r/344581 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbcfbefe2983b2ed2e3b110518c16539cbb84d88 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: master Gerrit-Owner: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
