jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344175 )
Change subject: Introduce EntityDiffVisualizer interface and use it in
BasicEntityDiffVisualizer
......................................................................
Introduce EntityDiffVisualizer interface and use it in BasicEntityDiffVisualizer
Bug: T160656
Change-Id: I2b41d5c0ad0098dfeac0f479ed479494ddc61b7a
---
M repo/includes/Diff/BasicEntityDiffVisualizer.php
A repo/includes/Diff/EntityDiffVisualizer.php
2 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/Diff/BasicEntityDiffVisualizer.php
b/repo/includes/Diff/BasicEntityDiffVisualizer.php
index 657ae40..245deae 100644
--- a/repo/includes/Diff/BasicEntityDiffVisualizer.php
+++ b/repo/includes/Diff/BasicEntityDiffVisualizer.php
@@ -23,7 +23,7 @@
* @author Tobias Gritschacher < tobias.gritschac...@wikimedia.de >
* @author Daniel kinzler
*/
-class BasicEntityDiffVisualizer {
+class BasicEntityDiffVisualizer implements EntityDiffVisualizer {
/**
* @var IContextSource
diff --git a/repo/includes/Diff/EntityDiffVisualizer.php
b/repo/includes/Diff/EntityDiffVisualizer.php
new file mode 100644
index 0000000..c08778c
--- /dev/null
+++ b/repo/includes/Diff/EntityDiffVisualizer.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace Wikibase\Repo\Diff;
+
+use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\Repo\Content\EntityContentDiff;
+
+/**
+ * Service interface for rendering EntityContentDiffs as HTML.
+ *
+ * @license GPL-2.0+
+ * @author Amir Sarabadani <ladsgr...@gmail.com>
+ */
+interface EntityDiffVisualizer {
+
+ /**
+ * Renders a EntityContentDiffs as HTML.
+ *
+ * @param EntityContentDiff $diff
+ * @return string HTML
+ */
+ public function visualizeEntityContentDiff( EntityContentDiff $diff );
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/344175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b41d5c0ad0098dfeac0f479ed479494ddc61b7a
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
