jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344380 )

Change subject: Don't change text colour on hover for things which aren't the 
target
......................................................................


Don't change text colour on hover for things which aren't the target

This will confuse the user into thinking they are in
the text's click area, when they are not.

Bug: T157720
Change-Id: I6b15da9750e14459d8784918e28f1a3e8d4a2661
---
M styles/control-attribution.less
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  JGirault: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/styles/control-attribution.less b/styles/control-attribution.less
index 8e0facd..a64fcbc 100644
--- a/styles/control-attribution.less
+++ b/styles/control-attribution.less
@@ -42,11 +42,10 @@
                overflow: hidden;
                text-overflow: clip;
                white-space: normal;
-
        }
 
        a {
-               color: @color-base;
+               color: @color-primary;
        }
 }
 
@@ -54,8 +53,4 @@
 .mw-kartographer-map:hover .mw-kartographer-attribution,
 .mw-kartographer-interactive:hover .leaflet-right.leaflet-bottom {
        background-color: rgba( 255, 255, 255, 0.9 );
-
-       a { /* stylelint-disable-line no-descending-specificity */
-               color: @color-primary;
-       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/344380
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b15da9750e14459d8784918e28f1a3e8d4a2661
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: JGirault <jgira...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to