jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344802 )
Change subject: DiffTreeNode: Use getters for type and attributes ...................................................................... DiffTreeNode: Use getters for type and attributes Avoids undefined object accesses. Change-Id: I1d3be11df2f6522cb5d38ea356fc59730bd39112 --- M src/ve.DiffTreeNode.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/src/ve.DiffTreeNode.js b/src/ve.DiffTreeNode.js index 964cef4..3dbf09e 100644 --- a/src/ve.DiffTreeNode.js +++ b/src/ve.DiffTreeNode.js @@ -42,8 +42,8 @@ return JSON.stringify( this.doc.getData( this.node.getOuterRange() ) ) === JSON.stringify( otherNode.doc.getData( otherNode.node.getOuterRange() ) ); } else { - return ( this.node.element.type === otherNode.node.element.type && - ve.compare( this.node.element.attributes, otherNode.node.element.attributes ) ); + return ( this.node.getType() === otherNode.node.getType() && + ve.compare( this.node.getAttributes(), otherNode.node.getAttributes() ) ); } }; -- To view, visit https://gerrit.wikimedia.org/r/344802 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d3be11df2f6522cb5d38ea356fc59730bd39112 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits