jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344783 )
Change subject: Move -hasDescriptions class toggle into #renderDiff
......................................................................
Move -hasDescriptions class toggle into #renderDiff
Makes more sense to have it here.
Change-Id: I72b6c9a1b816df9f1112177abc64233e628e6417
---
M src/ui/elements/ve.ui.DiffElement.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ui/elements/ve.ui.DiffElement.js
b/src/ui/elements/ve.ui.DiffElement.js
index 379735a..ff20f1c 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -57,8 +57,8 @@
this.$sidebar.append( this.descriptions.$element )
)
.addClass( 've-ui-diffElement' );
+
this.renderDiff();
- this.$element.toggleClass( 've-ui-diffElement-hasDescriptions',
!this.descriptions.isEmpty() );
};
/* Inheritance */
@@ -294,6 +294,8 @@
documentNode.innerHTML = '';
documentNode.appendChild( noChanges );
}
+
+ this.$element.toggleClass( 've-ui-diffElement-hasDescriptions',
!this.descriptions.isEmpty() );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/344783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72b6c9a1b816df9f1112177abc64233e628e6417
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
