jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344618 )
Change subject: Check for string initialization in lcfirst() for HHVM 3.18
......................................................................
Check for string initialization in lcfirst() for HHVM 3.18
HHVM 3.18 emits a notice when attempting to access the first offset of
an empty string. We had that fixed for ucfirst() in 3605066c96. This is
the same for lcfirst().
Bug: T161095
Change-Id: I1456611222c24290f259298e883ca89dd830c74b
---
M languages/classes/LanguageKk.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/languages/classes/LanguageKk.php b/languages/classes/LanguageKk.php
index 0460a6c..3a50987 100644
--- a/languages/classes/LanguageKk.php
+++ b/languages/classes/LanguageKk.php
@@ -408,7 +408,7 @@
* @return string
*/
function lcfirst( $string ) {
- if ( $string[0] == 'I' ) {
+ if ( substr( $string, 0, 1 ) === 'I' ) {
$variant = $this->getPreferredVariant();
if ( $variant == 'kk-latn' || $variant == 'kk-tr' ) {
return 'ı' . substr( $string, 1 );
--
To view, visit https://gerrit.wikimedia.org/r/344618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1456611222c24290f259298e883ca89dd830c74b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.29.0-wmf.17
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Aklapper <aklap...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Thcipriani <tcipri...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
