Mforns has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344914 )
Change subject: Fix domain_abbrev_map job to disambiguate wikimedia projects ...................................................................... Fix domain_abbrev_map job to disambiguate wikimedia projects This script was generating ambiguous records for <lang>.wikimedia projects. For example: dbname = arwikimedia, for which was generating ar.m, which is the same as arwiki for mobile site. Hence the resulting map table was not deterministic and wrong. The documentation in https://wikitech.wikimedia.org/wiki/Analytics/Data/Pagecounts-all-sites makes it clear that the .m suffix for xyz.wikimedia sites is only considered for the following wikis: commons.wikimedia.org meta.wikimedia.org incubator.wikimedia.org species.wikimedia.org strategy.wikimedia.org outreach.wikimedia.org usability.wikimedia.org quality.wikimedia.org SO, this change removes all <lang>.wikimedia.org from the table because they are not considered (and hence irrepresentable) by the webstatscollector abbreviation system. Bug: T156388 Change-Id: I041f5463de24d5c250c176af684ece11ed65b533 --- M bin/generate-domain-abbrev-map 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Mforns: Verified; Looks good to me, approved diff --git a/bin/generate-domain-abbrev-map b/bin/generate-domain-abbrev-map index c0e4f42..8794e25 100755 --- a/bin/generate-domain-abbrev-map +++ b/bin/generate-domain-abbrev-map @@ -108,7 +108,11 @@ return [ wiki for wiki in wikis - if 'private' not in wiki + if ( + 'private' not in wiki and + 'dbname' in wiki and + not wiki['dbname'].endswith('wikimedia') + ) ] def dbname_to_webstatscollector_abbreviation(dbname, site='desktop'): -- To view, visit https://gerrit.wikimedia.org/r/344914 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I041f5463de24d5c250c176af684ece11ed65b533 Gerrit-PatchSet: 3 Gerrit-Project: analytics/refinery Gerrit-Branch: master Gerrit-Owner: Mforns <mfo...@wikimedia.org> Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org> Gerrit-Reviewer: Joal <j...@wikimedia.org> Gerrit-Reviewer: Mforns <mfo...@wikimedia.org> Gerrit-Reviewer: Nuria <nu...@wikimedia.org> Gerrit-Reviewer: Ottomata <ao...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
