Mobrovac has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/345780 )
Change subject: Drop min-edits value ...................................................................... Drop min-edits value It's quite common during a 24 hour period for an article to receive less than 30 edits but to be one of the top edits for a day. Min speed cut off is 0.1 30/300 = 0.1 so this means anything that doesn't reach 30 edits will be lost after 5hrs. For example Donald Harvey got 27 edits today by 17 editors and 6 anons but was lost after trending for 6 hours. The combination with min_editors of 3 means the bar is still high enough to avoid the cache getting too big. Bug: T160127 Change-Id: I78e941bb434921886612ff4565c04399eedc1912 --- M scap/templates/config.yaml.j2 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mobrovac: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2 index cb621f2..8bb9bc6 100644 --- a/scap/templates/config.yaml.j2 +++ b/scap/templates/config.yaml.j2 @@ -84,7 +84,7 @@ # minimum speed in edits per minute that a page is kept around min_speed: 0.1 trends_at: # Defines a state where min_speed no longer applies - min_edits: 30 + min_edits: 15 min_editors: 3 # the number of edits needed to take a page into account min_edits: <%= min_edits %> -- To view, visit https://gerrit.wikimedia.org/r/345780 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78e941bb434921886612ff4565c04399eedc1912 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/services/trending-edits/deploy Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits