AndyRussG has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345862 )
Change subject: Comments flagging possibly unused code for inline banner
previews
......................................................................
Comments flagging possibly unused code for inline banner previews
Bug: T161907
Change-Id: I393c663c5da9181658463b50f1aa136297c78259
---
M includes/CNBannerPager.php
M includes/HtmlFormElements/HTMLCentralNoticeBanner.php
M resources/infrastructure/centralnotice.js
M special/SpecialCentralNoticeBanners.php
4 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/62/345862/1
diff --git a/includes/CNBannerPager.php b/includes/CNBannerPager.php
index 58eb8b5..739e4f2 100644
--- a/includes/CNBannerPager.php
+++ b/includes/CNBannerPager.php
@@ -1,5 +1,7 @@
<?php
+// FIXME Unused? See T161907
+
class CNBannerPager extends ReverseChronologicalPager {
/** @var bool True if the form is to be created with editable elements
*/
diff --git a/includes/HtmlFormElements/HTMLCentralNoticeBanner.php
b/includes/HtmlFormElements/HTMLCentralNoticeBanner.php
index 37fe807..4a7d8d3 100644
--- a/includes/HtmlFormElements/HTMLCentralNoticeBanner.php
+++ b/includes/HtmlFormElements/HTMLCentralNoticeBanner.php
@@ -22,6 +22,8 @@
* @file
*/
+// FIXME Unused? See T161907
+
/**
* Produces a banner preview DIV that can be embedded in an HTMLForm.
*
diff --git a/resources/infrastructure/centralnotice.js
b/resources/infrastructure/centralnotice.js
index 14081b5..f90f4f0 100644
--- a/resources/infrastructure/centralnotice.js
+++ b/resources/infrastructure/centralnotice.js
@@ -43,6 +43,7 @@
location.href = baseUrl + '?log=' + logType;
};
+ // FIXME Unused? See T161907
window.addEventListener( 'message', receiveMessage, false );
function receiveMessage( event ) {
var remoteData = JSON.parse( event.data );
diff --git a/special/SpecialCentralNoticeBanners.php
b/special/SpecialCentralNoticeBanners.php
index 5d09a83..45abcd5 100644
--- a/special/SpecialCentralNoticeBanners.php
+++ b/special/SpecialCentralNoticeBanners.php
@@ -461,6 +461,7 @@
$formDescriptor = array();
/* --- Banner Preview Section --- */
+ // FIXME Unused? See T161907
$formDescriptor[ 'preview' ] = array(
'section' => 'preview',
'class' => 'HTMLCentralNoticeBanner',
--
To view, visit https://gerrit.wikimedia.org/r/345862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I393c663c5da9181658463b50f1aa136297c78259
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <andrew.green...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
