AndyRussG has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345864 )
Change subject: Add FIXME comments in centralnotice.js
......................................................................
Add FIXME comments in centralnotice.js
Change-Id: Id5c2b496a36343bc5fad5ee54412313c013ee9d9
---
M resources/infrastructure/centralnotice.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/64/345864/1
diff --git a/resources/infrastructure/centralnotice.js
b/resources/infrastructure/centralnotice.js
index f90f4f0..59935b9 100644
--- a/resources/infrastructure/centralnotice.js
+++ b/resources/infrastructure/centralnotice.js
@@ -1,6 +1,10 @@
/**
* CentralNotice Administrative UI - Common Functions
*/
+
+// FIXME Encapsulate logic specific to Special:CentralNoticeLogs
+// FIXME Global functions
+
( function ( mw, $ ) {
mw.centralNotice = mw.centralNotice || {};
mw.centralNotice.adminUi = {};
@@ -81,8 +85,8 @@
);
// Do the fancy multiselector; but we have to wait for some
arbitrary time until the
- // CSS has been applied... Yes, this is an egregious hack until
I rewrite the mutliselector
- // to NOT suck -- e.g. make it dynamic... whoo...
+ // CSS has been applied.
+ // FIXME This is a hack.
setTimeout( function () {
$( 'select[multiple="multiple"]' ).multiselect(
{ sortable: false, dividerLocation: 0.5 }
--
To view, visit https://gerrit.wikimedia.org/r/345864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5c2b496a36343bc5fad5ee54412313c013ee9d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
