jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/345289 )
Change subject: Center only buttons and not text in tables ...................................................................... Center only buttons and not text in tables Centering all the texts makes me seasick. It could be that we should center some text content but start with have them all to the left and just the button centered. Also added prefix on details CSS class. Change-Id: Ic5117383dee030dfe5443d2b2d6aedda0ad780d3 --- M modules/css/ext.PerformanceInspector.css M modules/templates/modulescss.mustache 2 files changed, 10 insertions(+), 7 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/css/ext.PerformanceInspector.css b/modules/css/ext.PerformanceInspector.css index 559c3fc..0eca3f9 100644 --- a/modules/css/ext.PerformanceInspector.css +++ b/modules/css/ext.PerformanceInspector.css @@ -51,7 +51,7 @@ table.mw-pi-inspector { vertical-align: middle; - text-align: center; + text-align: left; width: 100%; } @@ -62,7 +62,10 @@ padding: 0.5em; } -td.details { +td.mw-pi-details { vertical-align: top; - text-align: left; +} + +td.mw-pi-center { + text-align: center; } diff --git a/modules/templates/modulescss.mustache b/modules/templates/modulescss.mustache index 52a20f0..9f4c3ab 100644 --- a/modules/templates/modulescss.mustache +++ b/modules/templates/modulescss.mustache @@ -23,12 +23,12 @@ <td> {{selectors}} </td> - <td> + <td class="mw-pi-center"> <span class="mw-pi-button"></span> </td> </tr> <tr class="toggleable hidden"> - <td colspan="5" class="details" > + <td colspan="5" class="mw-pi-details" > {{#unmatchedSelectors}} <p>{{.}}</p> {{/unmatchedSelectors}} @@ -59,12 +59,12 @@ <td> {{selectors}} </td> - <td> + <td class="mw-pi-center"> <span class="mw-pi-button"></span> </td> </tr> <tr class="toggleable hidden"> - <td colspan="5" class="details"> + <td colspan="5" class="mw-pi-details"> {{#unmatchedSelectors}} <p>{{.}}</p> {{/unmatchedSelectors}} -- To view, visit https://gerrit.wikimedia.org/r/345289 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5117383dee030dfe5443d2b2d6aedda0ad780d3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/PerformanceInspector Gerrit-Branch: master Gerrit-Owner: Phedenskog <phedens...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits