Divec has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345955 )
Change subject: When setting ce=true/false on a ve.ce.DocumentNode, change descendants too ...................................................................... When setting ce=true/false on a ve.ce.DocumentNode, change descendants too Bug: T161944 Change-Id: I81f16a3bbcd2412b210c28fb584f64a434a60802 --- M src/ce/nodes/ve.ce.DocumentNode.js 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/55/345955/1 diff --git a/src/ce/nodes/ve.ce.DocumentNode.js b/src/ce/nodes/ve.ce.DocumentNode.js index 3664a1e..5774c49 100644 --- a/src/ce/nodes/ve.ce.DocumentNode.js +++ b/src/ce/nodes/ve.ce.DocumentNode.js @@ -67,6 +67,7 @@ * @method */ ve.ce.DocumentNode.prototype.disable = function () { + this.setDescendantsEditable( false ); this.$element.prop( 'contentEditable', 'false' ); }; @@ -77,6 +78,21 @@ */ ve.ce.DocumentNode.prototype.enable = function () { this.$element.prop( 'contentEditable', 'true' ); + this.setDescendantsEditable( true ); +}; + +/** + * Enable or disable editing on descendant ActiveNodes + * @private + * @param {boolean} isEditable + */ +ve.ce.DocumentNode.prototype.setDescendantsEditable = function ( isEditable ) { + var editable = isEditable ? 'true' : 'false'; + this.traverse( function ( node ) { + if ( node.activeNodeSurface !== undefined ) { + node.$element.prop( 'contentEditable', editable ); + } + } ); }; /* Registration */ -- To view, visit https://gerrit.wikimedia.org/r/345955 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I81f16a3bbcd2412b210c28fb584f64a434a60802 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Divec <da...@troi.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits