Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346201 )
Change subject: Remove DiffElement DOM element when destroying ...................................................................... Remove DiffElement DOM element when destroying Bug: T161877 Change-Id: I1631c4c160ff2bcf4fdbb466ed6294bd6a2f8be3 --- M src/ui/elements/ve.ui.DiffElement.js 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/01/346201/1 diff --git a/src/ui/elements/ve.ui.DiffElement.js b/src/ui/elements/ve.ui.DiffElement.js index 1b16c29..c97385c 100644 --- a/src/ui/elements/ve.ui.DiffElement.js +++ b/src/ui/elements/ve.ui.DiffElement.js @@ -190,6 +190,7 @@ */ ve.ui.DiffElement.prototype.destroy = function () { $( this.getElementWindow() ).off( 'resize', this.onWindowResizeDebounced ); + this.$element.remove(); }; /** -- To view, visit https://gerrit.wikimedia.org/r/346201 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1631c4c160ff2bcf4fdbb466ed6294bd6a2f8be3 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits