jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/345660 )
Change subject: Wrap yaml load in file context managers ...................................................................... Wrap yaml load in file context managers Change-Id: I8b424749ceb6dd55b8c0b729a0546ec654cdd650 --- M processcontrol/config.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Cdentinger: Looks good to me, approved jenkins-bot: Verified diff --git a/processcontrol/config.py b/processcontrol/config.py index 2828293..c7771a4 100644 --- a/processcontrol/config.py +++ b/processcontrol/config.py @@ -85,7 +85,8 @@ Later entries override earlier entries. """ if os.access(CONFIG_PATH, os.R_OK): - config = yaml.safe_load(open(CONFIG_PATH, "r")) + with open(CONFIG_PATH, "r") as f: + config = yaml.safe_load(f) self.values.update(config) self.validate_global_config() @@ -107,7 +108,10 @@ else: defaults = {} Configuration.__init__(self, defaults) - self.values.update(yaml.safe_load(open(config_path, "r"))) + + with open(config_path, "r") as f: + self.values.update(yaml.safe_load(f)) + # TODO: Catch and interpret errors. self.validate_job_config() -- To view, visit https://gerrit.wikimedia.org/r/345660 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b424749ceb6dd55b8c0b729a0546ec654cdd650 Gerrit-PatchSet: 2 Gerrit-Project: wikimedia/fundraising/process-control Gerrit-Branch: master Gerrit-Owner: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits