Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346668 )
Change subject: Pass event to showSettings ...................................................................... Pass event to showSettings The parameter is expected and not optional. Bug: T162324 Change-Id: I9dea04eb7435f9349e60d477f5701ec5dd655ebd --- M src/renderer.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/68/346668/1 diff --git a/src/renderer.js b/src/renderer.js index 2045823..876c1a5 100644 --- a/src/renderer.js +++ b/src/renderer.js @@ -280,7 +280,7 @@ .click( function ( event ) { event.stopPropagation(); - behavior.showSettings(); + behavior.showSettings( event ); } ); } -- To view, visit https://gerrit.wikimedia.org/r/346668 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9dea04eb7435f9349e60d477f5701ec5dd655ebd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits