JGonera has uploaded a new change for review. https://gerrit.wikimedia.org/r/51580
Change subject: Change the way main page is detected ...................................................................... Change the way main page is detected Looking for "Today's featured article" is Wikipedia-specific. Looking for the div tag is not very elegant but it seems to be the only thing that always distinguishes the main page from other pages. Change-Id: Ib9315f076b4f3f0c894dfa465baaacdf616f7b9d --- M tests/acceptance/features/step_definitions/search_steps.rb M tests/acceptance/features/support/pages/home_page.rb 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/80/51580/1 diff --git a/tests/acceptance/features/step_definitions/search_steps.rb b/tests/acceptance/features/step_definitions/search_steps.rb index f02cb82..33aaf99 100644 --- a/tests/acceptance/features/step_definitions/search_steps.rb +++ b/tests/acceptance/features/step_definitions/search_steps.rb @@ -1,5 +1,5 @@ Given /^I am on the home page$/ do - visit(HomePage).text.should include "Today's featured article" + visit(HomePage).main_page_element.should exist end When /^I type (.+)$/ do |search_term| diff --git a/tests/acceptance/features/support/pages/home_page.rb b/tests/acceptance/features/support/pages/home_page.rb index 2e5bb20..0472f83 100644 --- a/tests/acceptance/features/support/pages/home_page.rb +++ b/tests/acceptance/features/support/pages/home_page.rb @@ -32,4 +32,5 @@ a(:disclaimer_link, text: 'Disclaimers') form(:search_form, id: 'mw-mf-searchForm') a(:sign_up, text: 'Sign up') + div(:main_page, id: 'mainpage') end -- To view, visit https://gerrit.wikimedia.org/r/51580 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9315f076b4f3f0c894dfa465baaacdf616f7b9d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: JGonera <jgon...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
