[MediaWiki-commits] [Gerrit] CSS changes for question mark and move core notices down. - change (mediawiki...GettingStarted)

[Mattflaschen (Code Review)]

Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/51614


Change subject: CSS changes for question mark and move core notices down.
......................................................................

CSS changes for question mark and move core notices down.

Change-Id: I811a710d45cba2f5f3564c9c6d6ad7f2eb4c5499
---
M resources/ext.gettingstarted.accountcreation.js
M resources/ext.gettingstarted.css
2 files changed, 17 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/14/51614/1

diff --git a/resources/ext.gettingstarted.accountcreation.js 
b/resources/ext.gettingstarted.accountcreation.js
index 53a296e..56b5b99 100644
--- a/resources/ext.gettingstarted.accountcreation.js
+++ b/resources/ext.gettingstarted.accountcreation.js
@@ -5,6 +5,7 @@
                        $returnTo = $( '#mw-returnto' ),
                        $returnToA = $returnTo.find( 'a' ),
                        $onboardingContainer = $( '.onboarding-container' ),
+                       $notices,
                        state,
                        url;
 
@@ -18,9 +19,14 @@
                $returnTo.empty().append( $returnToA );
                $onboardingContainer.append( $returnTo );
 
-               state = {}; // Currently unused
-               url = mw.util.wikiGetlink( 'Special:GettingStarted' );
+               // Mainly intended for email confirmation message, but others 
are possible.
+               // There is not a more specific selector in core for this.
+               $notices = $( '#mw-content-text > p' );
+               $notices.insertAfter( $onboardingContainer );
+
                if ( history.replaceState ) {
+                       state = {}; // Currently unused
+                       url = mw.util.wikiGetlink( 'Special:GettingStarted' );
                        history.replaceState( state, title, url );
                }
        } );
diff --git a/resources/ext.gettingstarted.css b/resources/ext.gettingstarted.css
index cda8abf..7789c45 100644
--- a/resources/ext.gettingstarted.css
+++ b/resources/ext.gettingstarted.css
@@ -17,19 +17,15 @@
 
 .onboarding-help {
        display: inline-block;
-       margin-left: 0.5em;
-       color: #999;
-       font-weight: bold;
-       font-size: 11px;
-       line-height: 11px;
-       width: 16px;
-       height: 16px;
-       text-align: center;
 }
 
-.onboarding-help:hover {
-       color: #222;
+.onboarding-help img {
+       opacity: 0.6;
+}
+
+.onboarding-help img:hover {
        cursor: pointer;
+       opacity: 1;
 }
 
 /********************* Header Banner *********************/
@@ -98,8 +94,9 @@
        -o-filter: grayscale(0%);
 }
 
-/********************* Email Notification *********************/
-#mw-content-text > p:first-child {
+/********************* Notifications *********************/
+/* Core currently doesn't offer any more stable selector. */
+#mw-content-text > p {
        font-size: 0.8em;
        color: gray;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/51614
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I811a710d45cba2f5f3564c9c6d6ad7f2eb4c5499
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: feature/gettingstartedv2
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits