Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347206 )
Change subject: Dropping IE9: Remove disableUneditableContent from
DesktopArticleTarget
......................................................................
Dropping IE9: Remove disableUneditableContent from DesktopArticleTarget
Bug: T162277
Change-Id: Ibb38284573078098c2173232239e9836a8161f56
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
2 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/06/347206/1
diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
index 0c0f9d7..27c5b00 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.init.css
@@ -44,7 +44,6 @@
.ve-loading #content > :not( .ve-init-mw-desktopArticleTarget-loading-overlay
),
/* Once activated, all uneditable content except catlinks */
.ve-activated .ve-init-mw-desktopArticleTarget-uneditableContent {
- /* IE9 is supported with JS events */
pointer-events: none;
-webkit-user-select: none;
-moz-user-select: none;
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 665cb97..75b6417 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -878,7 +878,6 @@
}
$categories = $( $.parseHTML( response.parse.categorieshtml ) );
target.transformCategoryLinks( $categories );
- target.disableUneditableContent( $categories );
mw.hook( 'wikipage.categories' ).fire( $categories );
$( '#catlinks' ).replaceWith( $categories );
} );
@@ -1239,8 +1238,6 @@
$content = $content.parent();
}
- this.disableUneditableContent();
-
this.updateHistoryState();
};
@@ -1264,18 +1261,6 @@
} else {
$catlinks.addClass(
've-init-mw-desktopArticleTarget-uneditableContent' ).off( '.ve-target' );
}
-};
-
-/**
- * Disabling of non-editable content, in a given context
- *
- * @param {jQuery|string} [context] Context to disable in
- */
-ve.init.mw.DesktopArticleTarget.prototype.disableUneditableContent = function
( context ) {
- $( '.ve-init-mw-desktopArticleTarget-uneditableContent', context ).on(
'click.ve-target', function ( e ) {
- // Support IE9: Prevent default, but don't stop propagation
- e.preventDefault();
- } );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/347206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb38284573078098c2173232239e9836a8161f56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
