Phuedx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347600 )
Change subject: reducers: Make PREVIEW_SHOW require a token ...................................................................... reducers: Make PREVIEW_SHOW require a token Like the FETCH_COMPLETE and ABANDON_END actions, the PREVIEW_SHOW action was delayed but not conditionally reduced. As ABANDON_END is delayed, there's a potential for a race and if ABANDON_END is reduced before PREVIEW_SHOW, then there's no interaction to reduce the action into, which causes an error, e.g. T159490#3165276 and T162373. Making PREVIEW_SHOW require a token stops the error occurring in this scenario. An alternative would be to clear the timeout created in ext.popups.Preview#show in #hide. However, this would be inconsistent with actions#fetch and actions#abandon. Bug: T159490 Change-Id: Ibd2c0c6f45e4392582cc6ed08517f6ca1146d57a --- M resources/dist/index.js M resources/dist/index.js.map M src/reducers/eventLogging.js M tests/node-qunit/reducers/eventLogging.test.js 4 files changed, 18 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/00/347600/1 -- To view, visit https://gerrit.wikimedia.org/r/347600 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd2c0c6f45e4392582cc6ed08517f6ca1146d57a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
