Aaron Schulz has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348005 )
Change subject: Add comments to ApiBase::isWriteMode()
......................................................................
Add comments to ApiBase::isWriteMode()
Change-Id: I3581f5e3055c425367d265a5c57831bb34dd5a2f
---
M includes/api/ApiBase.php
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/348005/1
diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index b698cef..37750c8 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -385,6 +385,13 @@
/**
* Indicates whether this module requires write mode
+ *
+ * This should return true for modules that may require synchronous
database writes.
+ * Modules that do not need such writes should also not rely on master
database access,
+ * since only read queries are needed and each master DB is a single
point of failure.
+ * Additionally, requests that only need replica DBs can be efficiently
routed to any
+ * datacenter via the Promise-Non-Write-API-Action header.
+ *
* @return bool
*/
public function isWriteMode() {
--
To view, visit https://gerrit.wikimedia.org/r/348005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3581f5e3055c425367d265a5c57831bb34dd5a2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
