Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348145 )

Change subject: jquery.tablesorter: Disable a flaky isoDate test case
......................................................................

jquery.tablesorter: Disable a flaky isoDate test case

This one varies by local timezone. To be fixed up later.

Change-Id: I42f3684b721d4c8a9a687adbaf0b4f770c1f057d
---
M tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/45/348145/1

diff --git 
a/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js 
b/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
index c0b1657..fd1fa49 100644
--- a/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js
@@ -179,7 +179,6 @@
                [ '2000-01-01', true, 946684800000, 'Year with month and day' ],
                [ '2000-13-01', true, -Infinity, 'Non existant month' ],
                [ '2000-01-32', true, -Infinity, 'Non existant day' ],
-               [ '2000-01-01T12:30:30',                true, 946729830000, 
'Date with a time' ],
                [ '2000-01-01T12:30:30Z',       true, 946729830000, 'Date with 
a UTC+0 time' ],
                [ '2000-01-01T24:30:30Z',       true, -Infinity, 'Date with 
invalid hours' ],
                [ '2000-01-01T12:60:30Z',       true, -Infinity, 'Date with 
invalid minutes' ],
@@ -206,6 +205,8 @@
                [ '2000-01-01T12:30:30-24:00',  true, 946816230000, 'Date time 
in UTC-24' ],
                [ '2000-01-01T12:30:30+24:00',  true, 946643430000, 'Date time 
in UTC+24' ],
                [ '2000-01-01T12:30:30+0100',   true, 946726230000, 'Time 
without separator in timezone offset' ]
+               // No "Z", uses local timezone:
+               [ '2000-01-01T12:30:30',                true, 946729830000, 
'Date with a time' ],
                */
        ];
        parserTest( 'ISO Dates', 'isoDate', ISODates );

-- 
To view, visit https://gerrit.wikimedia.org/r/348145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42f3684b721d4c8a9a687adbaf0b4f770c1f057d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to