jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/348159 )
Change subject: RCFilters: Followup I42be06913: Destroy tag widget when removing ...................................................................... RCFilters: Followup I42be06913: Destroy tag widget when removing Change-Id: Ifa051dd88dd36fa8ab14eacbeaea49f9aa0dbcdc --- M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js index 5fdcb68..2461929 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js @@ -256,6 +256,7 @@ function () { widget.scrollToTop( menuOption.$element ); } ); }; + /** * @inheritdoc */ @@ -264,6 +265,8 @@ mw.rcfilters.ui.FilterTagMultiselectWidget.parent.prototype.onTagRemove.call( this, tagItem ); this.controller.clearFilter( tagItem.getName() ); + + tagItem.destroy(); }; /** -- To view, visit https://gerrit.wikimedia.org/r/348159 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa051dd88dd36fa8ab14eacbeaea49f9aa0dbcdc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits