jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348292 )
Change subject: MediaWiki theme: Fit icon/indicator & label in
DecoratedOptionWidget
......................................................................
MediaWiki theme: Fit icon/indicator & label in DecoratedOptionWidget
Making icon/indicator & label combinations perfectly fit in
DecoratedOptionWidget. Removing hack after T87835 is in place as
follow-up to If34ab5302767.
Change-Id: I2b7841a930773f57956116bbb7a3e8ee63aa0caa
---
M src/themes/mediawiki/widgets.less
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 9e4f13b..ffba95e 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -513,8 +513,12 @@
line-height: @line-height-widget-singleline;
}
- &.oo-ui-indicatorElement .oo-ui-indicatorElement-indicator {
- right: @padding-horizontal-default;
+ &.oo-ui-indicatorElement {
+ padding-right: @size-indicator + @padding-horizontal-default;
+
+ .oo-ui-indicatorElement-indicator {
+ right: @padding-horizontal-default;
+ }
}
&.oo-ui-widget-disabled {
@@ -756,11 +760,6 @@
background-color: @background-color-progressive-hover;
color: @color-progressive;
}
- }
-
- // Reset from DecoratedOptionWidget. FIXME: Remove after T87835 is fixed
- &.oo-ui-iconElement {
- padding-left: @padding-horizontal-default;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/348292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7841a930773f57956116bbb7a3e8ee63aa0caa
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
