Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348322 )
Change subject: Only add 'sysop' group to filter user if not in it
......................................................................
Only add 'sysop' group to filter user if not in it
This should avoid repeated, unnecessary calls to User::addGroup().
Bug: T163032
Change-Id: I010e6eb45c4fbf984a3b5e5df2671117ca4e0136
---
M includes/AbuseFilter.class.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter
refs/changes/22/348322/1
diff --git a/includes/AbuseFilter.class.php b/includes/AbuseFilter.class.php
index c857ac1..f4b9e62 100644
--- a/includes/AbuseFilter.class.php
+++ b/includes/AbuseFilter.class.php
@@ -1876,7 +1876,9 @@
}
// Promote user so it doesn't look too crazy.
- $user->addGroup( 'sysop' );
+ if ( !in_array( 'sysop', $user->getGroups() ) ) {
+ $user->addGroup( 'sysop' );
+ }
return $user;
}
--
To view, visit https://gerrit.wikimedia.org/r/348322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I010e6eb45c4fbf984a3b5e5df2671117ca4e0136
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
