jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/348200 )
Change subject: Don't load entire codebase in QUnit tests ...................................................................... Don't load entire codebase in QUnit tests As noted in T160406, the only QUnit tests that requires a running MediaWiki instance is the test for mw.popups.processLinks. The function itself is isolated from the rest of the codebase. Now, as noted in T162876#3182198, during boot the ext.eventLogging.Schema module is loaded asynchronously with mw.loader.using. Since boot is unconditional and happens ASAP this happens when the tests are loaded and run. In the short term this can be avoided by not making the tests depend on the entire codebase. The long term solution is laid out in T160406. Supporting changes: * Bundle assets with [email protected]. Bug: T162876 Change-Id: If1ee1853ba7a9b2a66b24bb93b4e6062b92b0dba --- M includes/PopupsHooks.php M resources/dist/index.js M resources/dist/index.js.map 3 files changed, 7 insertions(+), 15 deletions(-) Approvals: Krinkle: Looks good to me, but someone else must approve Hashar: Looks good to me, but someone else must approve jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/348200 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ee1853ba7a9b2a66b24bb93b4e6062b92b0dba Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
