jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348593 )
Change subject: Add stylelint for css files
......................................................................
Add stylelint for css files
Fixed the following rules:
indentation
color-named
no-duplicate-selectors
Change-Id: I0f54800df94c90d293519400ce5df97f1c1448a3
---
A .stylelintrc
M Gruntfile.js
M modules/ext.MassMessage.special.css
M modules/ext.MassMessage.validation.css
M package.json
5 files changed, 22 insertions(+), 8 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/.stylelintrc b/.stylelintrc
new file mode 100644
index 0000000..d691e9d
--- /dev/null
+++ b/.stylelintrc
@@ -0,0 +1,6 @@
+{
+ "extends": "stylelint-config-wikimedia",
+ "rules": {
+ "selector-no-id": null
+ }
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index a0d8906..2c1e1ed 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -4,8 +4,9 @@
grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-jscs' );
- var conf = grunt.file.readJSON( 'extension.json' );
+ grunt.loadNpmTasks( 'grunt-stylelint' );
+ var conf = grunt.file.readJSON( 'extension.json' );
grunt.initConfig( {
jshint: {
options: {
@@ -22,11 +23,18 @@
jsonlint: {
all: [
'**/*.json',
+ '.stylelintrc',
+ '!node_modules/**'
+ ]
+ },
+ stylelint: {
+ all: [
+ '**/*.css',
'!node_modules/**'
]
}
} );
- grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana' ]
);
+ grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana',
'stylelint' ] );
grunt.registerTask( 'default', 'test' );
};
diff --git a/modules/ext.MassMessage.special.css
b/modules/ext.MassMessage.special.css
index 0a7dc2b..a0c5946 100644
--- a/modules/ext.MassMessage.special.css
+++ b/modules/ext.MassMessage.special.css
@@ -4,5 +4,5 @@
#mw-massmessage-form .mw-htmlform-field-HTMLSubmitField,
#mw-massmessage-form .mw-htmlform-field-HTMLSubmitField .mw-label,
#mw-massmessage-form .mw-htmlform-field-HTMLSubmitField .mw-input {
- display: inline;
+ display: inline;
}
diff --git a/modules/ext.MassMessage.validation.css
b/modules/ext.MassMessage.validation.css
index cf9e319..296ceb6 100644
--- a/modules/ext.MassMessage.validation.css
+++ b/modules/ext.MassMessage.validation.css
@@ -2,12 +2,11 @@
Styles inline validation warnings
*/
#mw-massmessage-form-spamlist-status.invalid,
-#mw-input-wptitle-status.invalid,
#mw-input-wptitle-status.invalid {
border: 1px solid #d33;
border-bottom-right-radius: 0.8em;
border-top-right-radius: 0.8em;
background-color: #fee7e6;
- color: black;
+ color: #000;
padding: 2px 1em;
}
diff --git a/package.json b/package.json
index 54f4076..27905b7 100644
--- a/package.json
+++ b/package.json
@@ -3,11 +3,12 @@
"test": "grunt test"
},
"devDependencies": {
- "grunt": "0.4.5",
- "grunt-cli": "0.1.13",
+ "grunt": "1.0.1",
"grunt-contrib-jshint": "0.11.3",
"grunt-banana-checker": "0.4.0",
"grunt-jscs": "2.2.0",
- "grunt-jsonlint": "1.0.7"
+ "grunt-jsonlint": "1.0.7",
+ "grunt-stylelint": "0.6.0",
+ "stylelint-config-wikimedia": "0.4.1"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/348593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f54800df94c90d293519400ce5df97f1c1448a3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
