jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348568 )
Change subject: CSSJanus now flips transforms so .rtl rules break main menu
......................................................................
CSSJanus now flips transforms so .rtl rules break main menu
Since we upgraded CSS Janus in
Iad2ea202b7724edc8360ce74943e2026f57e1f06
these rules break RTL display of the main menu
Bug: T163059
Change-Id: Idb05ee3ec916cc3a724a1b1cb45733c9b4c2c7b7
---
M resources/mobile.mainMenu/mainmenu.less
1 file changed, 0 insertions(+), 26 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
Catrope: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/resources/mobile.mainMenu/mainmenu.less
b/resources/mobile.mainMenu/mainmenu.less
index 00c1459..75f0e88 100644
--- a/resources/mobile.mainMenu/mainmenu.less
+++ b/resources/mobile.mainMenu/mainmenu.less
@@ -269,29 +269,3 @@
width: 100%;
}
}
-
-.rtl {
- // FIXME: Make animations a conditional class on the drawer itself
- &.animations .notifications-overlay.navigation-drawer {
- // +2% to accommodate for the border/box-shadow
- .transform( translate( -102%, 0 ) );
-
- &.visible {
- .transform( translate( 0, 0 ) );
- }
- }
-
- &.primary-navigation-enabled.animations {
- // FIXME: Menu shouldn't need to know about drawers
- .drawer .position-fixed,
- #mw-mf-page-center {
- .transform( translate( -@menuWidth, 0 ) );
- }
- }
-
- &.secondary-navigation-enabled.animations {
- #mw-mf-page-center {
- .transform( translate( @rightDrawerWidth, 0 ) );
- }
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/348568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb05ee3ec916cc3a724a1b1cb45733c9b4c2c7b7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
