jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348127 )
Change subject: Temporarily disable smoke:16
......................................................................
Temporarily disable smoke:16
Looks like this is the only place we try to show suggestion box, and it doesn't
work.
To reduce noise, after manually testing suggestion box is not actually broken,
let us
disable it and look for why it may be failing.
The patch also cleans up some duplicate code and weird similar, but not quite
identical
scenario strings.
Change-Id: Id1420ae00c5b37b143ce52ee9907ca3392001e0c
---
M tests/browser/features/smoke.feature
M tests/browser/features/step_definitions/search_steps.rb
M tests/browser/features/step_definitions/simple_search_steps.rb
3 files changed, 7 insertions(+), 21 deletions(-)
Approvals:
Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
jenkins-bot: Verified
DCausse: Looks good to me, approved
diff --git a/tests/browser/features/smoke.feature
b/tests/browser/features/smoke.feature
index 1f5558e..0f3dccc 100644
--- a/tests/browser/features/smoke.feature
+++ b/tests/browser/features/smoke.feature
@@ -12,18 +12,18 @@
@clean @firefox @test2.wikipedia.org @phantomjs @smoke
Feature: Smoke test
- @en.wikipedia.beta.wmflabs.org
+ @en.wikipedia.beta.wmflabs.org @expect_failure
Scenario: Search suggestions
Given I am at a random page
- When I search for: main
- Then a list of suggested pages should appear
- And Main Page should be the first result
+ When I type main into the search box
+ Then suggestions should appear
+ And Main Page is the first suggestion
@expect_failure
Scenario: Fill in search term and click search
Given I am at a random page
- When I search for: ma
- And I click the search button
+ When I type ma into the search box
+ And I click the search button
Then I should land on Search Results page
@en.wikipedia.beta.wmflabs.org
diff --git a/tests/browser/features/step_definitions/search_steps.rb
b/tests/browser/features/step_definitions/search_steps.rb
index c015b6d..f71a846 100644
--- a/tests/browser/features/step_definitions/search_steps.rb
+++ b/tests/browser/features/step_definitions/search_steps.rb
@@ -233,9 +233,9 @@
end
Then(/^suggestions should( not)? appear$/) do |not_appear|
+ sleep(5)
if not_appear
# Wait to give the element a chance to load if it was going to
- sleep(5)
on(SearchPage).search_results_element.should_not be_visible
else
on(SearchPage).search_results_element.when_present.should be_visible
diff --git a/tests/browser/features/step_definitions/simple_search_steps.rb
b/tests/browser/features/step_definitions/simple_search_steps.rb
index 0687228..6cdcd14 100644
--- a/tests/browser/features/step_definitions/simple_search_steps.rb
+++ b/tests/browser/features/step_definitions/simple_search_steps.rb
@@ -9,24 +9,10 @@
# CirrusSearch top-level directory and at
#
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCirrusSearch/HEAD/CREDITS
#
-When(/^I search for: (.+)$/) do |search_term|
- on(SearchPage).search_input_element.when_present.send_keys(search_term)
-end
-
-Then(/^a list of suggested pages should appear$/) do
- with_browser do
- on(SearchPage).search_results_element.when_present.should exist
- end
-end
Then(/^I should land on Search Results page$/) do
with_browser do
on(SearchResultsPage).search_element.when_present
browser.url.should match Regexp.escape("&title=Special%3ASearch")
- end
-end
-Then(/^(.+) should be the first result$/) do |page_name|
- with_browser do
- on(SearchPage).first_result.should == page_name
end
end
--
To view, visit https://gerrit.wikimedia.org/r/348127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1420ae00c5b37b143ce52ee9907ca3392001e0c
Gerrit-PatchSet: 9
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: Tjones <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
